Fix PackageToJS plugin wasm-opt fallback when output file exists #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateinoigakukun
force-pushed
the
fix-packagetojs-wasm-opt-fallback
branch
3 times, most recently
from
6dca4f7 to
40c79f7
Compare
When wasm-opt is not installed, DefaultPackagingSystem falls back to copying the input Wasm file directly to output. However, FileManager.copyItem fails if the destination file already exists, while wasm-opt overwrites existing files. Changes: - Remove existing output file before copying in wasm-opt fallback - Make DefaultPackagingSystem injectable for testing with custom which function - Add focused tests for DefaultPackagingSystem fallback behavior - Test both new and existing output file scenarios Fixes issue where builds fail with 'File exists' error when wasm-opt is unavailable and output file already exists from previous builds.
kateinoigakukun
force-pushed
the
fix-packagetojs-wasm-opt-fallback
branch
from
40c79f7 to
b579fb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where PackageToJS builds fail when wasm-opt is not installed and the output file already exists.
The plugin falls back to copying the input file when wasm-opt is unavailable, but FileManager.copyItem throws an error if the destination exists. This causes "File exists" build failures.
The fix removes any existing output file before copying, matching wasm-opt's overwrite behavior. Also makes DefaultPackagingSystem injectable for cleaner testing.