fix(internet-header): add self admin url prop to override menu links #5941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 40d73f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Related Previews |
leagrdv
requested review from
oliverschuerch
and removed request for
oliverschuerch
…ink-for-the-selfadmin-when-the-logouturl-is-not-the-same-domain-as-the-user-profile-2
…ink-for-the-selfadmin-when-the-logouturl-is-not-the-same-domain-as-the-user-profile-2
|
oliverschuerch
requested changes
Sep 2, 2025
There was a problem hiding this comment.
Regarding the self-admin-origin prop in the docs:
- Group it with other controls in the "Overrides" section.
- Align the property naming (camel case).
- Add a clearer description, so users without internal knowledge can understand how and when to use it.
- Change the control type, so it becomes possible to define a value.
| ...(this.logoutUrl !== undefined | ||
| ? { platform: { ...platform, logoutURL: this.logoutUrl } } | ||
| : { platform }), | ||
| platform, |
There was a problem hiding this comment.
Suggested change
| platform, | |
| { platform }, |
| @@ -182,6 +187,7 @@ export class PostInternetHeader { | |||
| try { | |||
| state.projectId = this.project; | |||
| state.stickyness = this.stickyness; | |||
| state.selfAdminOrigin = this.selfAdminOrigin; | |||
There was a problem hiding this comment.
Is it necessary/smart to handle the selfAdminOrigin different than the logoutUrl here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Description
Created a new PR based on #4936 as the internet-header package was removed from v8.
@gfellerph The changes you requested in the previous PR have been adressed on this one.