-
Notifications
You must be signed in to change notification settings - Fork 19
chore(docs): updated minimum font-size 14px, changed font-size from px to rem #5964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(docs): updated minimum font-size 14px, changed font-size from px to rem #5964
Conversation
…sidebar-subheading and info classes in styles
…e class in styles
🦋 Changeset detectedLatest commit: 4299f23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Related Previews |
…https://github.com/swisspost/design-system into 5267-increase-overall-font-size-in-the-documentation
packages/components/src/components/post-footer/post-footer.scss
Outdated
Show resolved
Hide resolved
packages/components/src/components/post-mainnavigation/post-mainnavigation.scss
Outdated
Show resolved
Hide resolved
packages/components/src/components/post-megadropdown/post-megadropdown.scss
Outdated
Show resolved
Hide resolved
packages/internet-header/src/components/post-klp-login-widget/widget-styles.scss
Outdated
Show resolved
Hide resolved
…in-the-documentation' into 5267-increase-overall-font-size-in-the-documentation
Co-authored-by: Alona Zherdetska <[email protected]>
…in-the-documentation' into 5267-increase-overall-font-size-in-the-documentation
packages/documentation/src/stories/health/icons/icons.styles.scss
Outdated
Show resolved
Hide resolved
…t classes in stories on documentation
…ss in styles on docs, made code adapted to hold minimum font-size
…-tag in styles on docs
…ith integrated code tag in styles on docs, updated font-size in banner styles on docs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Quick question: What's the reasoning behind using rem for some elements and px for others?
📄 Description
For accessibility (WCAG 2.1 guidelines) the font-size smaller than 14px has been updated to 14px respectively 0.875rem.
Font-size in code-tag and plain text in UPPERCASE are still in former font-size.
For the font-size the unit is changed from px to rem.