Skip to content

validate pubkey from extended public key when parsed; validate extended key version #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

scgbckbone
Copy link
Contributor

No description provided.

…ed key has proper version wrt data it carries
Copy link
Contributor Author

@scgbckbone scgbckbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed here:

  • we allow to de-serialize extended public key that contains private key and vice-versa (we haven't checked the version vs data inside)
  • we allow to de-serialize extended public that contains invalid secp256k1 pubkey, for example 020000000000000000000000000000000000000000000000000000000000000007 (not a security issue here as invalid pubkey would raise exception when we start working with it, but this imo should be part of validation logic)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant