fix: make every effort to carry hidden states for dummy files

[sxyazi]

Which issue does this PR resolve?

Resolves #2751

Rationale of this PR

[Copilot]

Pull Request Overview

This PR aims to fix the handling of dummy files by ensuring that hidden states are consistently carried over through various file operations. Key changes include:

• Adding a "no-dummy" flag when revealing a file in the TabProxy.
• Replacing calls to File::from and Cha::dummy with updated methods like File::new, File::from_follow, and Cha::default.
• Updating collection construction (e.g. sets and maps) to use a more concise array-based syntax.

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
yazi-proxy/src/tab.rs	Injects an additional flag ("no-dummy") during file reveal operations to manage dummy states.
yazi-plugin/src/macros.rs	Adjusts the cached field construction for the cha field using the new tuple struct style.
yazi-plugin/src/fs/fs.rs	Modifies file metadata handling by replacing from_meta with from_follow.
yazi-plugin/src/external/{rga, rg, fd}.rs	Switches file creation API from File::from to File::new for consistent initialization.
yazi-plugin/src/bindings/cha.rs	Changes how Cha is instantiated by exposing the inner type as a public tuple field.
yazi-fs/src/{op, files, file}.rs	Updates file operations to use from_follow/new methods and modern array-based collection syntax.
yazi-fs/src/cha/cha.rs	Refactors Cha initialization, default values, and attachment of hidden states.
yazi-core/src/**/*.rs	Replaces Cha::dummy with Cha::default and updates file API calls in tab operations, commands, watcher, and rename flows.

Comments suppressed due to low confidence (13)

yazi-core/src/tab/commands/cd.rs:99

• Review that using File::new here ensures correct file type handling before proceeding with directory change and file reveal actions.

if let Ok(file) = File::new(url.clone()).await else { return };

yazi-plugin/src/fs/fs.rs:54

• Confirm that renaming from 'from_meta' to 'from_follow' maintains the intended behavior, especially in handling symlink cases.

Ok(m) => Cha(yazi_fs::cha::Cha::new(&url, m)).into_lua_multi(&lua),

yazi-plugin/src/external/rga.rs:32

• Verify that switching from File::from to File::new aligns with the updated file initialization logic and covers all edge cases.

if let Ok(file) = File::new(opt.cwd.join(line)).await {

yazi-fs/src/op.rs:128

• [nitpick] Confirm that the new array-based initialization for sets is consistent with our project style and does not introduce performance issues.

Self::Deleting(p, [n].into()).emit();

yazi-fs/src/files.rs:44

• Make sure that the behavior of File::from_follow meets the intended semantics, especially in scenarios where dummy file states are relevant.

Ok(meta) => File::from_follow(url, meta).await,

yazi-fs/src/file.rs:26

• Check that the transition from 'from' to 'new' (and using from_follow internally) correctly preserves and adapts file metadata retrieval logic.

pub async fn new(url: Url) -> Result<Self> {

yazi-core/src/tab/preview.rs:51

• Review the use of Cha::default() in place of Cha::dummy() to ensure it correctly represents the intended file state for stale directories.

let Some(new) = Files::assert_stale(&wd, dir.unwrap_or_default()).await else { return };

yazi-core/src/tab/folder.rs:49

• Confirm that replacing Cha::dummy() with Cha::default() preserves the proper semantics for folder loading scenarios.

(self.cha, self.stage) = (Cha::default(), FolderStage::Loading);

yazi-core/src/tab/commands/search.rs:73

• Ensure that switching from Cha::dummy() to Cha::default() in search commands properly reflects the file state in the search results.

FilesOp::Done(cwd, Cha::default(), ticket).emit();

yazi-core/src/mgr/watcher.rs:137

• Double-check that File::new properly handles symlink resolution and edge cases in the watcher context.

let Ok(file) = File::new(u).await else {

yazi-core/src/mgr/commands/open.rs:59

• Validate that invoking File::new in the open command correctly distinguishes between directories and files.

if let Ok(f) = File::new(u).await {

yazi-core/src/mgr/commands/create.rs:59

• Ensure that switching to File::new during file creation integrates well with subsequent file operations and state updates.

if let Ok(f) = File::new(new.clone()).await {

yazi-core/src/mgr/commands/bulk_rename.rs:97

• Confirm that using File::new in bulk rename operations maintains the integrity of file metadata during batch processing.

else if let Ok(f) = File::new(new.into()).await {

[Copilot]

Please document the purpose and effect of the "no-dummy" flag so future maintainers understand its impact.

[Copilot]

[nitpick] Ensure that constructing Cha with a tuple struct (Cha(me.cha)) is consistent with our type conversion conventions throughout the codebase.

[Copilot]

[nitpick] Evaluate whether exposing the inner yazi_fs::cha::Cha directly via a public tuple field is intended and does not break abstraction boundaries.

[Copilot]

[nitpick] Ensure consistent set initialization across rename operations to avoid potential mismatches in file identifiers.

Suggested change

	FilesOp::Deleting(p_old, [n_old].into()).emit();
	FilesOp::Deleting(p_old, [UrnBuf::from(n_old)].into()).emit();