Skip to content

add twig parameter for TurboStreamListenRenderer #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dbu
Copy link

@dbu dbu commented Aug 4, 2025

workaround for #94

until #94 is cleanly solved, this would allow to install mercure-bundle and symfony/ux-turbo in their latest versions.

i see that ux-turbo does provide a RegisterMercureHubsPass so maybe the proper solution here would be to just remove this service definition (and declare a conflict with symfony/ux-turbo versions that do not have that compiler pass)

@chalasr
Copy link
Member

chalasr commented Aug 4, 2025

Adding $twig as non-optional parameter is a BC break in ux-turbo though, introduced in symfony/ux#2447

@dbu
Copy link
Author

dbu commented Aug 5, 2025

Adding $twig as non-optional parameter is a BC break in ux-turbo though, introduced in symfony/ux#2447

yes.
but its been there for several patch versions now, so i don't expect it to be reverted again, that would create a new mess.

@dbu
Copy link
Author

dbu commented Aug 5, 2025

build failure is not related to the changes in this bundle. symfony/mercure claims to be compatible with PHP 7 but its own tests fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants