Skip to content

Lazy loaded Twig Extension #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions src/Twig/MercureExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,14 @@
use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Component\Mercure\Authorization;
use Symfony\Component\Mercure\HubRegistry;
use Twig\Extension\AbstractExtension;
use Twig\TwigFunction;
use Twig\Attribute\AsTwigFunction;

/**
* Registers the Twig helper function.
*
* @author Kévin Dunglas <[email protected]>
*/
final class MercureExtension extends AbstractExtension
final class MercureExtension
{
private $hubRegistry;
private $authorization;
Expand All @@ -37,17 +36,13 @@ public function __construct(HubRegistry $hubRegistry, ?Authorization $authorizat
$this->requestStack = $requestStack;
}

public function getFunctions(): array
{
return [new TwigFunction('mercure', [$this, 'mercure'])];
}

/**
* @param string|string[]|null $topics A topic or an array of topics to subscribe for. If this parameter is omitted or `null` is passed, the URL of the hub will be returned (useful for publishing in JavaScript).
* @param array{subscribe?: string[]|string, publish?: string[]|string, additionalClaims?: array<string, mixed>, lastEventId?: string, hub?: string} $options The options to pass to the JWT factory
*
* @return string The URL of the hub with the appropriate "topic" query parameters (if any)
*/
#[AsTwigFunction('mercure')]
public function mercure($topics = null, array $options = []): string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could keep this function in this class and use the #[TwigFunction] attribute to make this extension lazy.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{
$hub = $options['hub'] ?? null;
Expand Down
Loading