[Map] Do not override fitBoundsToMarkers when using LiveComponent
#2811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dannyvw
commented
Jun 2, 2025
dannyvw
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| Docs? | yes |
| Issues | Fix #2774 |
| License | MIT |
carsonbot
added
Status: Needs Review
|
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
Kocal
changed the title
fitBoundsToMarkers when using it with LiveComponent
Kocal
reviewed
Jun 10, 2025
There was a problem hiding this comment.
I was a little skeptical at first, but it does make more sense.
Can you :
- modify the changelog accordingly, since it could be interpreted as a breaking-change
- modify the documentation on using Map with LiveComponents, and add an example with
$this->getMap()->fitBoundsToMarkers(false)?
Thank you very much!
Kocal
added
Status: Needs Work
carsonbot
added
Status: Needs Review
Kocal
changed the title
fitBoundsToMarkers when using it with LiveComponentfitBoundsToMarkers when using it with LiveComponent
Kocal
changed the title
fitBoundsToMarkers when using it with LiveComponentfitBoundsToMarkers when using LiveComponent
carsonbot
added
Status: Reviewed
|
Thank you @dannyvw. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.