Skip to content

[Map] Do not override fitBoundsToMarkers when using LiveComponent #2811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

dannyvw
Copy link
Contributor

@dannyvw dannyvw commented Jun 2, 2025

Q A
Bug fix? no
New feature? yes
Docs? yes
Issues Fix #2774
License MIT

@dannyvw dannyvw requested a review from Kocal as a code owner June 2, 2025 08:49
@carsonbot carsonbot added Status: Needs Review Needs to be reviewed Feature New Feature Map labels Jun 2, 2025
@carsonbot
Copy link

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

@Kocal Kocal changed the title [Map] Use fitboundstomarker configuration [Map] Do not force fitBoundsToMarkers when using it with LiveComponent Jun 10, 2025
Copy link
Member

@Kocal Kocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a little skeptical at first, but it does make more sense.

Can you :

  • modify the changelog accordingly, since it could be interpreted as a breaking-change
  • modify the documentation on using Map with LiveComponents, and add an example with $this->getMap()->fitBoundsToMarkers(false)?

Thank you very much!

@Kocal Kocal added Status: Needs Work Additional work is needed and removed Status: Needs Review Needs to be reviewed labels Jun 10, 2025
@carsonbot carsonbot added Status: Needs Review Needs to be reviewed and removed Status: Needs Work Additional work is needed labels Jun 10, 2025
@Kocal Kocal changed the title [Map] Do not force fitBoundsToMarkers when using it with LiveComponent [Map] Do not override fitBoundsToMarkers when using it with LiveComponent Jun 10, 2025
@Kocal Kocal changed the title [Map] Do not override fitBoundsToMarkers when using it with LiveComponent [Map] Do not override fitBoundsToMarkers when using LiveComponent Jun 10, 2025
Copy link
Member

@Kocal Kocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified some documentation

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Jun 10, 2025
@Kocal
Copy link
Member

Kocal commented Jun 10, 2025

Thank you @dannyvw.

@Kocal Kocal merged commit 9d7ec20 into symfony:2.x Jun 10, 2025
23 of 24 checks passed
@Kocal Kocal deleted the map-fitbounds branch June 10, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature Map Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Map] FitBoundsToMarkers
3 participants