-
-
Notifications
You must be signed in to change notification settings - Fork 361
[Autocomplete] Add maxOptions: null
to autocomplete with remote data
#2817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.x
Are you sure you want to change the base?
Conversation
📊 Packages dist files size differenceThanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kevinmade ! Thank you for this suggestion.
You need to make your changes on the source code of the controller.
Here, you changes are done on the dist
file, that will be re-computed from the source everytime someone make a change, and your suggestion will be lost.
Also, it will be easier to review with a bit of context, some link to documentation or source code impacted, etc.
BeforeScreencast.from.2025-06-05.15-00-22.mp4AfterScreencast.from.2025-06-05.15-00-48.mp4 |
maxOptions: null
to autocomplete with remote data
When seeing your demo, I think it breaks the spirit of "autocompletion". To me, you have to type something and the component autocomplete you some results, but here, it looks like a lazy-loaded I'm not really against your suggestion, but not in this way. Instead, can we keep it 50 items by default but introduce a new option? |
This fixes an issue where the autocomplete component stops loading additional results after 50 due to default limit. The maxOptions value has been set to null to allow loading more than 50 options from the
autocomplete_url
.