Add support for testing large return values (> 255) #232
+74
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, test suite was limited to verifying return values between 0-255 due to Unix exit code constraints. It made testing functions with larger return values awkward, requiring workarounds like "(fib(16) - 987) == 0". This commit introduces a new try_large() function that: - Wraps test code in a test_function() that returns the value to test - Uses printf to output the return value instead of exit codes - Compares the printed output against expected values Close #152
|
Looks good to me. This approach using printf makes it easier for future contributors to extend support to non-integer types if needed. It also allows us to test the printf formatting of large integers (e.g., %x, %o). |
fennecJ
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, test suite was limited to verifying return values between 0-255 due to Unix exit code constraints. It made testing functions with larger return values awkward, requiring workarounds like "(fib(16) - 987) == 0".
This commit introduces a new try_large() function that:
Close #152
Summary by Bito
This pull request enhances the testing framework by introducing the try_large function, which allows for testing return values exceeding 255. This modification addresses limitations of Unix exit codes, enabling more accurate function output verification.