chore: socketless types in Clover #6912
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.Scanned FilesNone |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first turn of a change to remove sockets from Clover assets. To do this safely, we want to be able to bring it down piece by piece (so we don't have a single giant unreviewable Clover diff and avoid unintended consequences).
How does this PR change the system?
This PR does not remove sockets; it remove sockets from the default SchemaVariant types in Clover, and adds back equivalent
SchemaVariantWithSocketstypes, which we use only in pipeline stages that actually do socket stuff.Then the plan is to burn down Clover sockets stage by stage, removing
WithSocketsusage, checking what changed at each point.How was it tested?
In short: 🔗