Skip to content

Conversation

jobelenus
Copy link
Contributor

@jobelenus jobelenus commented Aug 29, 2025

How does this PR change the system?

  1. On a cold start, store the MvIndex data as an atom
  2. After patches complete, we get an IndexUpdate message
  3. That message now has patch data for the MvIndex itself
  4. Apply that patch
  5. Remove MTMs that aren't on the index

Added a fn to heimdall that will allow you to ask whether a kind & id exist on the index. This way, we can prompt the user that: "Yes—this component doesn't exist" vs "it may exist but we dont have it yet"

How was it tested?

  1. Load the page
  2. Use the rune menu to call Odin
  3. See the MvIndex data stored
  4. Go to a component detail page, remove characters from the component ID, so it will not find one, see the existence check fire without failure.
  5. Make a change
  6. Odin again
  7. see the index checksum on the MvIndex atom is updated.
  8. ensure that MTMs for HEAD are not altered

Copy link

github-actions bot commented Aug 29, 2025

Dependency Review

✅ No vulnerabilities or OpenSSF Scorecard issues found.

Scanned Files

None

@jobelenus jobelenus force-pushed the jobelenus/store-mv-index-sqlite branch from 1b8f2b4 to eba91b2 Compare August 29, 2025 18:28
@jobelenus jobelenus force-pushed the jobelenus/store-mv-index-sqlite branch 2 times, most recently from f90a7e8 to 7537454 Compare August 29, 2025 19:05
zacharyhamm
zacharyhamm previously approved these changes Aug 29, 2025
…cycle

Use the mvIndex to tell whether or not a component ought to exist
delete mtms that dont exist on the index
@jobelenus jobelenus force-pushed the jobelenus/store-mv-index-sqlite branch from 0738ace to 17b08fc Compare September 3, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants