fix: compiler crashes when a contract name exceeds filesystem limits #3219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return full; | ||
| } | ||
|
|
||
| const hash = sha256_sync(Buffer.from(name)).toString("hex").slice(0, 8); |
There was a problem hiding this comment.
2^32 hashes are still possible to mine, possibly creating a name clash
I think it would rather be better to just err whenever len(projectName) + len(contractName) + 1 >= 255, or even len(projectName) > 100 || len(contractName) > 100.
These are not the kind of situations that might happen in non-malicious code, and emitting an error would be completely fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #3138.
Now, if the filename is longer than 255 characters (including the extension), it will truncate part of the contract name in the filename and use the following format: contractnametruncated_contractnamehash(0,8).ext
I've checked, all the files for the same contract would have same hash
Checklist