Skip to content

Conversation

bartwe
Copy link

@bartwe bartwe commented Aug 12, 2024

depends upon thatcosmonaut#163

thatcosmonaut and others added 30 commits August 9, 2024 11:16
Co-authored-by: Caleb Cornett <[email protected]>
Co-authored-by: Ethan Lee <[email protected]>
Co-authored-by: Zakary Strange <[email protected]>
Always check return value of VULKAN_INTERNAL_QuerySwapchainSupport(), if 1st call to vkGetPhysicalDeviceSurfacePresentModesKHR() fails then outputDetails->formatsLength is not 0 but outputDetails->formats is still not initialised.
Always free outputDetails->formats on error in VULKAN_INTERNAL_QuerySwapchainSupport().
Use correct type for allocation of commandBuffer->presentDatas.
Do some allocations later to avoid memory leaks on error.
This should clarify the usage of the parameters in the Upload/Download functions.
@Akaricchi Akaricchi force-pushed the gpu_render branch 6 times, most recently from 66aaf8e to c5fafed Compare August 19, 2024 22:46
@Akaricchi Akaricchi force-pushed the gpu_render branch 4 times, most recently from ec68b78 to c021268 Compare August 29, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants