Skip to content

terminal command lisa accepts directory name #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

chrisosaurus
Copy link
Contributor

This makes lisa more consistent with katie.

Copy link
Collaborator

@nriley nriley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the community backlog session we discussed this and felt it was a good idea for consistency, however we would prefer if you made the path argument optional to avoid breaking any existing argumentless uses of the actions.

@nriley nriley self-assigned this Jan 18, 2025
@nriley
Copy link
Collaborator

nriley commented Jan 18, 2025

Changes made as I recommended.

@nriley nriley requested review from nriley and removed request for nriley January 18, 2025 19:25
nriley
nriley previously approved these changes Jan 18, 2025
@nriley nriley self-requested a review January 18, 2025 19:27
@nriley nriley dismissed their stale review January 18, 2025 19:28

Cannot seem to remove myself as reviewer and should not be reviewing my own changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants