Add more features to discord app #1806
Conversation
for more information, see https://pre-commit.ci
| @@ -18,7 +34,9 @@ current call: user.discord_go_current_call() | |||
| toggle pins: user.discord_toggle_pins() | |||
| toggle inbox: user.discord_toggle_inbox() | |||
| toggle (members | member list): user.discord_toggle_members() | |||
| toggle (vee see text | voice text): user.discord_toggle_members() | |||
There was a problem hiding this comment.
Have you tried this with v c text instead? This usually works fine with conformer and is a bit more intention revealing.
| (create | join) server: user.discord_create_join_server() | ||
| create private group: user.discord_create_private_group() | ||
| open support: user.discord_open_support() | ||
| start low fie: user.discord_start_lofi() |
There was a problem hiding this comment.
From the community backlog session — I realize we do not have a lot of consistency here (issue on this is incoming) already but with new voice commands we tend to prefer a noun verb syntax.
There was a problem hiding this comment.
Do you guys have a standard method of deprecating commands? If so, I could deprecate the prior syntax and convert to the new syntax.
There was a problem hiding this comment.
Yup! See core/deprecations.py and BREAKING_CHANGES.txt.
| # Forward Message: F | ||
|
|
||
| # Navigation: Messages | ||
| go oldest unread: user.discord_channel_oldest_unread() |
There was a problem hiding this comment.
From the community backlog session — this should probably go into messaging.talon and have a syntax more similar to the existing commands for navigating around unread channels.
| def discord_channel_oldest_unread(): | ||
| actions.key("shift-pageup") | ||
|
|
||
| def discord_open_support(): |
There was a problem hiding this comment.
Wondering if this should be a more general command to open help rather than something discord specific.
There was a problem hiding this comment.
Personally, I'm for it being a general command. However, I'm unsure as to what a clean syntax for that would look like. Help is already taken. It could be app help maybe?
Is there a standard way of handling common functionalities between applications that need to be differentiated from talon ones?
There was a problem hiding this comment.
Sure, you could consider defining a tag for it, or (probably better in this case) implementing it for an entire platform at a time via an action.
app help sounds good to me too; there's a similar feature for settings/preferences going in with #1841.
|
I'll try to get back to this in the next couple of days. |
Went through the Discord help list and tried to add any feature that wasn't already supported. I haven't gotten the chance to completely test everything yet as I am not on Windows. I wasn't sure how to approach handling editing messages though.
The message editing commands are currently sitting as a set of comments in the talon file. I thought about possibly having a context flag that would set a tag for messages being focused. Something like "focus messages" that tabs once, and then they could navigate up and down. Then, they would be able to use an edit command, reply command, etc. However, I wanted to get other people's thoughts on that before doing something more complex like that.
I looked at the contribution guidelines and they say to prefer object verb but the structure is already verb object so I'm not sure whether it should be redesigned or left in that form.