Skip to content

Commented out EditActions that don't work with the default iterm2 settings #1846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

caroby
Copy link
Contributor

@caroby caroby commented May 12, 2025

Now it defaults to ctrl-a and ctrl-e in readline.py which always works.

@BlueDrink9
Copy link
Contributor

I know iterm is clever, but I would never have expected the original to work. Strange. That sort of thing is handled at the shell level, not the terminal level. I think it would be less confusing to delete them rather than comment them though.

This probably will need chiming in from at least one other person that uses iterm. What's your shell?

@AndreasArvidsson
Copy link
Collaborator

I don't use Iterm, but we should definitely remove them and not just leave them commented if we don't want this functionality.

@auscompgeek
Copy link
Collaborator

As a fish in iTerm user (where both the Emacs keys and home/end work out of the box) I concur with the above. There's no reason to keep this commented out, let's just delete the code.

…tings

Now it defaults to ctrl-a and ctrl-e in readline.py which always works.
@caroby
Copy link
Contributor Author

caroby commented Jul 14, 2025

I deleted them instead. Without this fix, line_start() and line_end() do not work on iTerm with the out-of-the-box default settings on mac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants