Expand markdown snippets #1930
Expand markdown snippets #1930
Conversation
|
These were not planned as part of the migration itself, so no toe stepping. |
|
From the community backlog session — it looks like you are still working on this, so I have marked it as draft. Feel free to mark as ready for review once you are done with the requested changes or let us know if you have further questions. Thanks! |
|
oops, had forgotten to address issues. Will finalise today! |
| * [ ] $0 | ||
| --- | ||
|
|
||
| name: bold |
There was a problem hiding this comment.
Markdown syntax is not defined as bold/italic/bold italic but just as increasingly strong forms of emphasis; perhaps something like emph[asis]/strong/very strong? Even newer definitions like GitHub Flavored Markdown don't include any definitions of how the various emphasis formats should be rendered (see https://github.github.com/gfm/#emphasis-and-strong-emphasis)
There was a problem hiding this comment.
Hmm, that's an interesting note. Because intuitively, and for the purpose of saying things, I feel like most people would still refer to it as bold/italic, since that is the most common rendering fashioned by far. However, it is technically incorrect… Perhaps we just include both as options?
There was a problem hiding this comment.
I'm OK with that if the rendering is so consistent across different Markdown flavors/renderers.
There was a problem hiding this comment.
Added both in case anyone uses the other as a phrase. Other than that, ready to merge?
There was a problem hiding this comment.
Does that actually work with a portion of a word in []? I've never tried that.
There was a problem hiding this comment.
It does not. Only a-z and | is supported.
There was a problem hiding this comment.
Sorry, it was less than responsible of me to not test that. Fixed now, and tested
I'm hoping this doesn't end up stepping on the toes of efforts to migrate language specific things to snippets. These are some snippets that I expected to be there and were not