Add snippet stop at the end #1934
Open
+199
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
| # $value or ${value} or ${value:default} | ||
| return re.search(rf"\${variable_name}|\${{{variable_name}.*}}", body) is not None | ||
| return rf"\${variable_name}|\${{{variable_name}.*?}}" |
There was a problem hiding this comment.
Please add a comment why we need the ? a the end
|
Please test what happens if you don't have a $zero stop |
|
Feed back from the session. Instead of having a fixed replacement name we should find the highest numerical value and pick something that's larger than that. We should probably unit test this |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a snippet stop at the end of every snippet that does not already have one there to allow exiting the snippet with "snip next".
I replaced .* with .*? in the regular expression to match the smallest possible match to better handle multiple instances of the same snippet stop with default values.
Someone should probably test this other than me as breaking snippets would not be fun.