Skip to content

Fix csv writer #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2025
Merged

Fix csv writer #12

merged 2 commits into from
Aug 7, 2025

Conversation

ReverseTM
Copy link
Collaborator

@ReverseTM ReverseTM commented Aug 4, 2025

This pool request fixes a bug where the CSV format in partition mode did not honor the write_to_output option and would write the column header anyway. Also, the logic for skipping some columns has been moved to the model writer.

hackallcode
hackallcode previously approved these changes Aug 7, 2025
Copy link
Collaborator

@hackallcode hackallcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to make common logic for all outputs to skip some columns, but it's also ok.

Copy link
Collaborator

@hackallcode hackallcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@ReverseTM ReverseTM merged commit b27b2ad into tarantool:master Aug 7, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants