Skip to content

ci: add auto checks for commit message #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dmyger
Copy link
Collaborator

@dmyger dmyger commented Jul 14, 2025

Auto validation on CI for format of commit message.

  • Well-written commit messages (see documentation how to write a commit message)

Closes #TNTP-3712

@dmyger dmyger force-pushed the dmyger/tntp-3712_ci_checks_commit_message branch 5 times, most recently from 0f5ebe7 to 4be991f Compare July 14, 2025 16:30
@dmyger dmyger force-pushed the dmyger/tntp-3712_ci_checks_commit_message branch from 4be991f to 28693bd Compare July 14, 2025 16:57
Comment on lines +2 to +3
description: "Performs checks for commit messages format."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no launch conditions here, what event triggers it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at tests.yaml job check-commit-msg, this action runs on push event - if: github.event_name == 'push'

@dmyger dmyger requested a review from oleg-jukovec July 15, 2025 10:36
@patapenka-alexey
Copy link
Contributor

If check-commit-msg fails, will it stop all other jobs? If not, I think we should use needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants