Skip to content

add nats result backend - continuation #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rafalkrupinski
Copy link

@rafalkrupinski rafalkrupinski commented Aug 20, 2024

picking up from #13

  • use official pre-commit repos for mypy and ruff
  • upgraded taskiq in order to use PickleSerializer
  • use standard taskiq exception
  • removed old linters that were replaced by ruff

not sure if wemake-python-styleguide is used in any way...

black could be replaced by ruff-format too, but I'll leave it for another PR, this one has enough stuff already.

@rafalkrupinski
Copy link
Author

Hi, any chance anyone has a look at it? Thanks!

@chandr-andr
Copy link
Member

@rafalkrupinski Thank you very much for PR, in the future you can tag me if no one comes))

Copy link
Member

@chandr-andr chandr-andr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chandr-andr chandr-andr merged commit c98d848 into taskiq-python:develop Nov 2, 2024
8 checks passed
@chandr-andr
Copy link
Member

@rafalkrupinski Thanks for the PR, I've started releasing the new version.

@rafalkrupinski rafalkrupinski deleted the feature/add_nats_result_backend branch November 2, 2024 11:37
@chandr-andr
Copy link
Member

@rafalkrupinski New version is here - https://pypi.org/project/taskiq-nats/0.5.0/
Thanks for the PR!

@rafalkrupinski
Copy link
Author

@chandr-andr cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants