Skip to content

feat: add LSItemContentTypes and CFBundleTypeIconFile support for fileAssociations on macOS #13345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

kingsword09
Copy link
Contributor

@kingsword09 kingsword09 commented Apr 30, 2025

According to apple docs:

  1. LSItemContentTypes: CFBundleTypeExtensions has been deprecated since OS X v10.5, so LSItemContentTypes has been added. In macOS 10.5 and later, this key (when present) takes precedence over these type-identifier keys: CFBundleTypeExtensions, CFBundleTypeMIMETypes, CFBundleTypeOSTypes.
  2. CFBundleTypeIconFile: this key contains a string with the name of the icon file (.icns) to associate with this macOS document type. [feat] Support set fileAssociations icon #13302
  3. To avoid breaking changes, the attribute is set as optional.

@kingsword09 kingsword09 requested a review from a team as a code owner April 30, 2025 06:50
@github-project-automation github-project-automation bot moved this to 📬Proposal in Roadmap Apr 30, 2025
@FabianLars
Copy link
Member

Thanks for the PR! I think we need to think a tiny bit more about the icon support. We may wanna think about letting users specify the file path to the icns file on the dev system and copy it ourselves to where it's needed (iirc that's what we do for other icons/images) or alternatively check if bundling the icns file as a resource works and document that.
We probably should keep in mind that iOS' CFBundleTypeIconFiles works differently (multiple pngs instead of one icns) for that decision even if we don't support file assocs on ios yet.

Copy link
Contributor

Package Changes Through 40142ef

There are 6 changes which include tauri with minor, tauri-bundler with minor, tauri-utils with minor, tauri-cli with minor, @tauri-apps/cli with minor, @tauri-apps/api with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.5.0 2.6.0
tauri-utils 2.4.0 2.5.0
tauri-bundler 2.4.0 2.5.0
tauri-runtime 2.6.0 2.6.1
tauri-runtime-wry 2.6.0 2.6.1
tauri-codegen 2.2.0 2.2.1
tauri-macros 2.2.0 2.2.1
tauri-plugin 2.2.0 2.2.1
tauri-build 2.2.0 2.2.1
tauri 2.5.1 2.6.0
@tauri-apps/cli 2.5.0 2.6.0
tauri-cli 2.5.0 2.6.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📬Proposal
Development

Successfully merging this pull request may close these issues.

2 participants