Skip to content

fix(windows): Set drag and drop to false in window builder in disable_drag_and_drop_handler() #13399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

guillemcordoba
Copy link
Contributor

@guillemcordoba guillemcordoba commented May 8, 2025

Without this, disable_drag_and_drop_handler() does not change the bevahior of the tao windows.

For me, this ended up triggering this panic. This PR fixes this and I don't have the panic anymore.

@guillemcordoba guillemcordoba requested a review from a team as a code owner May 8, 2025 17:25
@github-project-automation github-project-automation bot moved this to 📬Proposal in Roadmap May 8, 2025
Copy link
Contributor

github-actions bot commented May 9, 2025

Package Changes Through b4b469e

There are 7 changes which include tauri-bundler with patch, tauri with minor, @tauri-apps/api with minor, tauri-cli with patch, @tauri-apps/cli with patch, tauri-runtime-wry with patch, tauri-utils with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.5.0 2.6.0
tauri-utils 2.4.0 2.5.0
tauri-bundler 2.4.0 2.4.1
tauri-runtime 2.6.0 2.6.1
tauri-runtime-wry 2.6.0 2.6.1
tauri-codegen 2.2.0 2.2.1
tauri-macros 2.2.0 2.2.1
tauri-plugin 2.2.0 2.2.1
tauri-build 2.2.0 2.2.1
tauri 2.5.1 2.6.0
@tauri-apps/cli 2.5.0 2.5.1
tauri-cli 2.5.0 2.5.1

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Copy link
Contributor

@Legend-Master Legend-Master left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been using this method for quite some now without hitting the panic, but anyways, this change makes sense to me, just not sure if we should do this on all platforms or just for Windows (doesn't really matter to be honest since other platforms don't have this restriction anyways)

@amrbashir sorry for the ping but I'm not entirely sure if this is fine or not, pinging you since you wrote most of the drag drop stuffs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📬Proposal
Development

Successfully merging this pull request may close these issues.

2 participants