Skip to content

feat: add option to not wait on notarization to finish #13521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

FabianLars
Copy link
Member

The first time you try to notarize an app can take multiple hours (apparently even days), very easily hitting the timeout of github actions (and consuming insane amounts of build minutes in private repos).

This PR offers a simple flag to opt out of the waiting mechanic with the drawback of not being able to staple the notarization ticket onto the app automatically.

In the future we probably should look into a timeout mechanic instead but this is more of a hotfix.

Note that i did not test this.

@FabianLars FabianLars requested a review from a team as a code owner May 28, 2025 12:53
@github-project-automation github-project-automation bot moved this to 📬Proposal in Roadmap May 28, 2025
@FabianLars FabianLars requested a review from lucasfernog May 28, 2025 12:53
@FabianLars
Copy link
Member Author

FabianLars commented May 28, 2025

With Note that i did not test this. i meant actual signing/notarizing not building the CLI 😭 what did i doooo ah it's the tests

@lucasfernog
Copy link
Member

since this is supposed to be a temporary measure i don't think it should be done in the config file; maybe a CLI option would be better? i feel like most people wouldn't use it anyway until they hit this particular problem, which is too late anyway...

@FabianLars
Copy link
Member Author

i wanted to add it as a cli flag at first but it also felt kinda weird idk (actually just couldn't think of an arg name...). will change it tomorrow-ish

also, i think we should even add this to our signing guide as a recommendation for the first notarization.

@FabianLars FabianLars marked this pull request as draft May 28, 2025 20:47
@FabianLars FabianLars added this to the 2.6 milestone May 31, 2025
Copy link
Contributor

Package Changes Through d6f5026

There are 9 changes which include tauri-bundler with minor, tauri with minor, tauri-cli with minor, tauri-codegen with minor, tauri-utils with minor, tauri-macos-sign with minor, @tauri-apps/api with minor, @tauri-apps/cli with minor, tauri-runtime-wry with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.5.0 2.6.0
tauri-utils 2.4.0 2.5.0
tauri-macos-sign 2.1.0 2.2.0
tauri-bundler 2.4.0 2.5.0
tauri-runtime 2.6.0 2.6.1
tauri-runtime-wry 2.6.0 2.6.1
tauri-codegen 2.2.0 2.3.0
tauri-macros 2.2.0 2.2.1
tauri-plugin 2.2.0 2.2.1
tauri-build 2.2.0 2.2.1
tauri 2.5.1 2.6.0
@tauri-apps/cli 2.5.0 2.6.0
tauri-cli 2.5.0 2.6.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars
Copy link
Member Author

still not tested (no notarization setup) and the changes also felt weird. was a bit more work than expected for a simple cli arg

@FabianLars FabianLars marked this pull request as ready for review May 31, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📬Proposal
Development

Successfully merging this pull request may close these issues.

2 participants