-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat: add option to not wait on notarization to finish #13521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
With |
since this is supposed to be a temporary measure i don't think it should be done in the config file; maybe a CLI option would be better? i feel like most people wouldn't use it anyway until they hit this particular problem, which is too late anyway... |
i wanted to add it as a cli flag at first but it also felt kinda weird idk (actually just couldn't think of an arg name...). will change it tomorrow-ish also, i think we should even add this to our signing guide as a recommendation for the first notarization. |
Package Changes Through d6f5026There are 9 changes which include tauri-bundler with minor, tauri with minor, tauri-cli with minor, tauri-codegen with minor, tauri-utils with minor, tauri-macos-sign with minor, @tauri-apps/api with minor, @tauri-apps/cli with minor, tauri-runtime-wry with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
still not tested (no notarization setup) and the changes also felt weird. was a bit more work than expected for a simple cli arg |
The first time you try to notarize an app can take multiple hours (apparently even days), very easily hitting the timeout of github actions (and consuming insane amounts of build minutes in private repos).
This PR offers a simple flag to opt out of the waiting mechanic with the drawback of not being able to staple the notarization ticket onto the app automatically.
In the future we probably should look into a timeout mechanic instead but this is more of a hotfix.
Note that i did not test this.