Fix: Modifications on task in multiple viewports #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, after modifying a task, it's updating only the task line where the command is issued (like \td for "done") and if the same task is being shown in another viewport, that line is not reflected with modifications. So, on saving the file, it reverts the modifications. To handle, updating the entire buffer on task modifications
|
@sdondley We would need to add some new test scenarios in order to make sure this works as expected! |
tbabej
force-pushed
the
master
branch
9 times, most recently
from
b549521 to
36652d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why this patch was never applied to master branch. Just trying to move this along with a proper pull request. See #176
Currently, after modifying a task, it's updating only the task line
where the command is issued (like \td for "done") and if the same task
is being shown in another viewport, that line is not reflected with
modifications.
So, on saving the file, it reverts the modifications.
To handle, updating the entire buffer on task modifications