Fully initialized object fix for a null options object passed to session #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 1, 2014 09:08
Also updated package.json to be platform independent
A null options for express.session still needs to be a string though
This fix constructs a complete session options object if one doesn't exist, including a default cookie object as well. The previous fix submitted was a bit too simplistic and made assumptions about the way session options are processed within expressjs. A fully constructed options object should avoid any problems with future changes in expressjs as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version reverts the unnecessary socket.io null options change and provides a completely initialized session options object if a null option has been passed in. This also constructs a cookie options object as well, using default values.
Still included from the previous commit, the prepublish element in package.json uses shelljs-nodecli to compile coffescript. This avoids cross-platform issues with Windows.