Skip to content

Add new options to reset/update activities #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: next-server
Choose a base branch
from

Conversation

ychebotarev
Copy link
Contributor

@ychebotarev ychebotarev commented Jun 2, 2025

What was changed

  • Add "--restore-options" flag to both temporal activity reset and temporal activity update-options
  • Change/fix shortened commands for "activity-id" and "activity-type" parameters.
  • Reordered parameters validation check so it happens before we call "Dial"

Why?

Users should be able to restore original activity options.

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor PR comment, but will want to wait to merge until tests are available (i.e. when next-server can get a new tagged release)

@ychebotarev
Copy link
Contributor Author

ychebotarev commented Jun 3, 2025

Only minor PR comment, but will want to wait to merge until tests are available (i.e. when next-server can get a new tagged release)

Note.
I updated server version to current main, because apparently we don't have "tag" for new server release.

@ychebotarev ychebotarev requested a review from cretz June 3, 2025 00:59
@cretz
Copy link
Member

cretz commented Jun 3, 2025

I updated server version to current main, because apparently we don't have "tag" for new server release.

👍 This is good so that we can add tests. However, since this is likely no rush since there's no released server to use this with, I think we should wait to merge until we can update go.mod with a server tag. If figure this will be quite soon anyways.

@ychebotarev
Copy link
Contributor Author

👍 This is good so that we can add tests.

tests are added.

I think we should wait to merge until we can update go.mod with a server tag. If figure this will be quite soon anyways.

This is merge to next-server. Why wait?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants