update directories + file extensions for vale #3712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, I have a feeling I know what's going on here -- we used to generate .mdx from .md files that were directly edited, we moved away from that approach a while ago, and we probably never updated the Vale rules, so we haven't been following them super closely as a consequence. We were never heavily, heavily all-in on Vale, so this is a legacy process, but it's one that we should bring back. Flagging @brianmacdonald-temporal here -- if we merge this, there's going to be a lot of boring Vale fix PRs that we might not even fully agree with. |
axfelix
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
All the
lintcommands in package.json are no-ops. Seems like they were targeting an outdated folder structure (the only mention of docs-src in the repo is a comment saying something was migrated from it).They were also only targeting .md files, while most new docs files are .mdx.
This PR updates the
lintcommand to run on all md and mdx files in /docs. The language-specific commands run on md and mdx files in /docs/develop/{language}.I'm not sure what the desired behavior actually is. There's potentially....a lot to fix.
