Support replication with arbitrary shard counts #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pglass
commented
Mar 11, 2025
| // LCM calcuates the least common multiple of a and b. | ||
| // | ||
| // https://en.wikipedia.org/wiki/Least_common_multiple#Using_the_greatest_common_divisor | ||
| func LCM(a, b int32) int32 { |
There was a problem hiding this comment.
There are surprisingly few small libraries for doing this, and I wasn't satisfied with their unit testing (just few cases). I figured these functions are so small that I'd implement them myself to avoid the dependency.
pglass
commented
Mar 11, 2025
| @@ -213,21 +225,56 @@ func (s *adminServiceProxyServer) StreamWorkflowReplicationMessages( | |||
| if !ok { | |||
| return serviceerror.NewInvalidArgument("missing cluster & shard ID metadata") | |||
| } | |||
| targetClusterShardID, sourceClusterShardID, err := history.DecodeClusterShardMD( | |||
There was a problem hiding this comment.
Not sure if this was my fault when I bumped the temporal version, but the target/source ids here were flipped.
I changed them to match "client/server" terminology of the history.DecodeClusterShardMD function?
I'm fine either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Support replication with arbitrary numbers of history shards.
Why?
Checklist
Closes
How was this tested: