Minor cleanups: interceptors and OpenAI Agents SDK #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tconley1428
reviewed
Jul 17, 2025
| @@ -46,16 +46,13 @@ async def _plan_searches(self, query: str) -> WebSearchPlan: | |||
|
|
|||
| async def _perform_searches(self, search_plan: WebSearchPlan) -> list[str]: | |||
| with custom_span("Search the web"): | |||
| num_completed = 0 | |||
There was a problem hiding this comment.
Do we want to do code cleanup which makes it different from the openai sample?
There was a problem hiding this comment.
No strong opinion personally. I didn't know this code was copied.
There was a problem hiding this comment.
Reverted. Doesn't seem much point if it's copied code.
dandavison
force-pushed
the
dan-0001-minor-cleanups
branch
from
569abcb to
9a0f59f
Compare
This reverts commit e7e3e12.
tconley1428
approved these changes
Jul 17, 2025
cretz
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.