Skip to content

External client configuration sample #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 12, 2025
Merged

External client configuration sample #228

merged 8 commits into from
Aug 12, 2025

Conversation

THardy98
Copy link
Contributor

What was changed

Basic samples for environment configuration, showing default usage and usage with a specific profile and environment variables overrides.

Partly addresses #178

  1. How was this tested:
    Samples run correctly

  2. Any docs updates needed?
    I don't think so

@THardy98 THardy98 requested a review from a team as a code owner July 29, 2025 14:08
@THardy98
Copy link
Contributor Author

Would like to wait for temporalio/sdk-core#968 before changing the existing samples, so we can simplify the diff (otherwise we'll need to read & load from a config file)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the updating of all existing samples to leverage the one-liner for loading from env config will be a separate PR?

Copy link
Contributor Author

@THardy98 THardy98 Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - I am updating samples to have their own TOML config (or shared) and loading from there.

Would need to release new version of Python SDK with temporalio/sdk-python#1004 included, to avoid samples needing to have TOML config for the default profile.

But I'd rather update these samples than wait for another release. Once the new release is out, we can update it accordingly (would be a small diff).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@THardy98 THardy98 requested a review from cretz August 12, 2025 03:25
@THardy98 THardy98 requested a review from cretz August 12, 2025 14:42
@THardy98 THardy98 merged commit c0b37a4 into main Aug 12, 2025
12 checks passed
@THardy98 THardy98 deleted the env_config_sample branch August 12, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants