-
Notifications
You must be signed in to change notification settings - Fork 81
External client configuration sample #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Would like to wait for temporalio/sdk-core#968 before changing the existing samples, so we can simplify the diff (otherwise we'll need to read & load from a config file) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume the updating of all existing samples to leverage the one-liner for loading from env config will be a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - I am updating samples to have their own TOML config (or shared) and loading from there.
Would need to release new version of Python SDK with temporalio/sdk-python#1004 included, to avoid samples needing to have TOML config for the default
profile.
But I'd rather update these samples than wait for another release. Once the new release is out, we can update it accordingly (would be a small diff).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was changed
Basic samples for environment configuration, showing default usage and usage with a specific profile and environment variables overrides.
Partly addresses #178
How was this tested:
Samples run correctly
Any docs updates needed?
I don't think so