Recursively rebuild models in openai.types #967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Jul 16, 2025
| @@ -15,6 +15,7 @@ | |||
|
|
|||
| from typing import Any, Optional, Type | |||
|
|
|||
| import pydantic.dataclasses | |||
There was a problem hiding this comment.
No, it was part of validating a lazy version
| @@ -1736,3 +1736,22 @@ async def test_workflow_method_tools(client: Client): | |||
| execution_timeout=timedelta(seconds=10), | |||
| ) | |||
| await workflow_handle.result() | |||
|
|
|||
|
|
|||
| async def test_response_serialization(): | |||
There was a problem hiding this comment.
I assume this test fails until openai/openai-agents-python#1131 (or equivalent) is merged?
There was a problem hiding this comment.
So... it does work if we explicitly rebuild all the models, but I'm hoping they will fix their dataclasses so we don't have to do this at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Recursively rebuild models in openai.types
Why?
In some scenarios, encoding would fail because the models had only been partially built on import
Checklist
Closes [Bug] pydantic_core._pydantic_core.PydanticSerializationError: Error serializing to JSON: TypeError: 'MockValSer' object cannot be converted to 'SchemaSerializer' #965
How was this tested:
New test
Any docs updates needed?