Skip to content

Add docs requirements as data file #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

smokestacklightnin
Copy link
Member

This fixes a build error by including the requrements-docs.txt file as a data file

@peytondmurray
Copy link
Contributor

Did you check whether this works? I don't think it's actually putting the requirements file in the right place. Is it possible that setuptools isn't finding it because it's in the root of the repo? https://setuptools.pypa.io/en/latest/userguide/datafiles.html#package-data

@smokestacklightnin
Copy link
Member Author

Did you check whether this works?

I actually don't believe it does. Closing this PR as a consequence.

Is it possible that setuptools isn't finding it because it's in the root of the repo?

This is what I believe to be the case. I also firmly believe that requirements-docs.txt should stay where it is located in the directory tree, rather than being inside the Python module, so this solution could never work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants