-
Notifications
You must be signed in to change notification settings - Fork 150
feat: expand async matcher support #1040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expand async matcher support #1040
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1040 +/- ##
==========================================
+ Coverage 96.30% 96.49% +0.18%
==========================================
Files 47 49 +2
Lines 2542 2679 +137
Branches 1047 1106 +59
==========================================
+ Hits 2448 2585 +137
Misses 94 94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I added some comments, but the implementation seems fine in general.
@all-contributors please add @puglyfe for code and test |
I've put up a pull request to add @puglyfe! 🎉 |
🎉 This PR is included in version 7.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Checks
Changes
This expands support for additional async matchers (specifically, jasmine) to reduce false positives for
await-async-queries
andawait-async-utils
. As mentioned in the linked issue, I understand any hesitancy to include framework-specific logic, but I think this is a relatively trivial addition to open up support to another testing framework.Context
Fixes #1039