Split Surjectivity #499
Merged
Split Surjectivity #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed pages
|
plt-amy
reviewed
May 20, 2025
plt-amy
reviewed
May 20, 2025
plt-amy
reviewed
May 20, 2025
plt-amy
reviewed
May 20, 2025
plt-amy
reviewed
May 20, 2025
ncfavier
reviewed
May 20, 2025
ncfavier
reviewed
May 20, 2025
ncfavier
reviewed
May 20, 2025
ncfavier
previously approved these changes
May 20, 2025
plt-amy
reviewed
Jun 17, 2025
plt-amy
reviewed
Jun 17, 2025
plt-amy
reviewed
Jun 17, 2025
plt-amy
reviewed
Jun 17, 2025
plt-amy
reviewed
Jun 17, 2025
|
This is probably ready now, up to merge conflicts? |
We should take the time to actually explain some of these equivalences at some point
Suggested-by: Amélia <[email protected]>
Suggested-by: Naïm Camille Favier <[email protected]>
Suggested-by: Naïm Camille Favier <[email protected]>
Suggested-by: Naïm Camille Favier <[email protected]>
TOTBWF
force-pushed
the
split-surjectivity
branch
from
a3e1736 to
84b724b
Compare
|
Rebased onto main, just need a ✅ and we are good to go. |
ncfavier
previously approved these changes
Aug 5, 2025
|
Looks like I missed some renames during the merge: mind giving this a final ✅ @ncfavier? |
ncfavier
previously approved these changes
Aug 5, 2025
|
Still blocked on @plt-amy 's approval |
plt-amy
requested changes
Aug 5, 2025
Suggested-by: Amélia <[email protected]>
plt-amy
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pulling some of my changes out of #375 in hopes of getting back to it at some point. This PR defines split surjectivity, and also proves some misc. lemmas about surjective maps. I've done some minor cleanup in some of the base modules, and added some (hopefully useful!) equivalences.
Checklist
Before submitting a merge request, please check the items below:
support/sort-imports.hs(ornix run --experimental-features nix-command -f . sort-imports).If your change affects many files without adding substantial content, and
you don't want your name to appear on those pages (for example, treewide
refactorings or reformattings), start the commit message and PR title with
chore:.