Skip to content

Commit 6d83a18

Browse files
committed
Fix some big bugs
Fixes #41 Fixes #43 Fixes #50
1 parent 9511c35 commit 6d83a18

File tree

4 files changed

+7
-5
lines changed

4 files changed

+7
-5
lines changed

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ minecraft_version=1.18.1
66
yarn_mappings=1.18.1+build.2
77
loader_version=0.12.12
88
# Mod Properties
9-
mod_version=1.0.0-bc.6
9+
mod_version=1.0.0-alpha.7
1010
maven_group=dev.thedocruby
1111
archives_base_name=resounding
1212
# Dependencies

src/main/java/dev/thedocruby/resounding/ResoundingEngine.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -681,9 +681,11 @@ private static double getBlockOcclusionD(final BlockState blockState) {
681681

682682
//TODO: Occlusion calculation here
683683

684+
double occlusion = RaycastFix.fixedRaycast(soundPos, listenerPos, mc.world, soundBlockPos, soundChunk).isMissed() ? 1 : 0; // TODO: occlusion coeff from processing goes here IF fancy or fabulous occl
685+
684686
directGain *= Math.pow(airAbsorptionHF, listenerPos.distanceTo(soundPos))
685687
/ Math.pow(listenerPos.distanceTo(soundPos), 2.0 * missedSum)
686-
* MathHelper.lerp(sharedSum, 0d/*TODO: occlusion coeff from processing goes here IF fancy or fabulous occl*/, 1d);
688+
* MathHelper.lerp(occlusion, sharedSum, 1d);
687689
double directCutoff = Math.pow(directGain, pC.globalAbsHFRcp); // TODO: make sure this actually works.
688690

689691
SoundProfile profile = new SoundProfile(sourceID, directGain, directCutoff, sendGain, sendCutoff);

src/main/java/dev/thedocruby/resounding/config/BlueTapePack/ConfigManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ private ConfigManager() {}
2626

2727
public static boolean resetOnReload;
2828

29-
public static final String configVersion = "1.0.0-bc.6";
29+
public static final String configVersion = "1.0.0-alpha.7";
3030

3131
@Environment(EnvType.CLIENT)
3232
public static final ResoundingConfig DEFAULT = ResoundingEngine.env == EnvType.CLIENT ? new ResoundingConfig(){{

src/main/java/dev/thedocruby/resounding/config/ResoundingConfig.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,10 +62,10 @@ public static class General{
6262
public int globalReverbGain = 75;
6363

6464
@Comment("The strength of the reverb effect.\n§7[•]§r Range: >= 0.0\n§7[•]§r Higher values make the echo last longer.\n§7[•]§r Lower values make the echos shorter.\n§a[+]§r Performance Impact: Low")
65-
public double globalReverbStrength = 1.0;
65+
public double globalReverbStrength = 2.5;
6666

6767
@Comment("The smoothness of the reverb.\n§7[•]§r Range: 0.0 - 1.0\n§7[•]§r Affects how uniform the reverb is.\n§7[•]§r Low values cause a distinct fluttering or bouncing echo.\n§7[•]§r High values make this effect less distinct by smoothing out the reverb.\n§a[+]§r Performance Impact: Low")
68-
public double globalReverbSmoothness = 0.5;
68+
public double globalReverbSmoothness = 0.618;
6969

7070
@Comment("The brightness of reverberation.\n§7[•]§r Range: > 0 \n§7[•]§r Higher values result in more high frequencies in reverberation.\n§7[•]§r Lower values give a more muffled sound to the reverb.\n§7[•]§r 1.0 is neutral.\n§a[+]§r Performance Impact: Low")
7171
public double globalReverbBrightness = 0.75;

0 commit comments

Comments
 (0)