Skip to content

48 pt2 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

48 pt2 #67

wants to merge 4 commits into from

Conversation

Pavlo3P
Copy link
Collaborator

@Pavlo3P Pavlo3P commented May 16, 2024

No description provided.

@Pavlo3P Pavlo3P requested review from PaulWAyers and RichRick1 May 16, 2024 19:13
RichRick1
RichRick1 requested changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@RichRick1 RichRick1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
The only thing I'd change is computing $\omega^\dagger$, when $T_2'$ is computed. We can use formula 2.67 from the Poelmans' thesis.

Also, we can use flat_tensor function from the rdm.tools module, in case we need to do something a little bit more fancy than just reshaping tensor to matrix in the future.

@Pavlo3P
Fixed T2'
39ff1c3 
Used formula (2.67) from Ward Poelmans' thesis for computing T2', flat_tensor function replaced reshaping in the formula.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RichRick1 RichRick1 RichRick1 requested changes

@PaulWAyers PaulWAyers Awaiting requested review from PaulWAyers

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Pavlo3P @RichRick1