zephyr-build-guide: define ZEPHYR_WORKSPACE before use #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SurajSonawane2415
requested review from
lgirdwood,
deb-intel,
intelkevinputnam,
mmaka1 and
mwasko
as code owners
lgirdwood
reviewed
Mar 7, 2025
| @@ -31,6 +31,7 @@ Initialize the west manifest ``$ZEPHYR_WORKSPACE/sof/west.yml`` using the ``west | |||
|
|
|||
| .. code-block:: bash | |||
|
|
|||
| ZEPHYR_WORKSPACE=~/zephyr_workspace | |||
There was a problem hiding this comment.
I think this is usually defined as ~/work/sof/zephyr
There was a problem hiding this comment.
@lgirdwood Yes you are correct! I looked into other build instructions, including build-from-scratch and build-with-docker to align the Zephyr path with this build guide—the correct path should be: ZEPHYR_WORKSPACE=~/work/sof/zephyr
SurajSonawane2415
force-pushed
the
fix-build-docs
branch
from
565ee84 to
9719bad
Compare
ZEPHYR_WORKSPACE is not defined before use. Defining it first, as done in 'Build toolchains and SOF from sources' where SOF_WORKSPACE is defined before use. Signed-off-by: Suraj Sonawane <[email protected]>
SurajSonawane2415
force-pushed
the
fix-build-docs
branch
from
9719bad to
e9ca17f
Compare
lgirdwood
approved these changes
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZEPHYR_WORKSPACEwas not defined before use. This update ensures it is defined first, similar to howSOF_WORKSPACEis defined before use in "Build toolchains and SOF from sources".I encountered this issue while building SOF with Zephyr using this document, where
ZEPHYR_WORKSPACEwas not defined. DefiningZEPHYR_WORKSPACEbefore use resolves the problem.Testing
Generated the HTML documentation locally using:
make -C sof-docs VERBOSE=1 htmlI would appreciate your review and any suggestions for improvement. Thank you!