Skip to content

Forward kwargs correctly for calls in context #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/shoulda/context/context.rb
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,8 @@ def test_name_prefix
end
end

def method_missing(method, *args, &blk)
test_unit_class.send(method, *args, &blk)
def method_missing(...)
test_unit_class.send(...)
end
end

Expand Down
8 changes: 4 additions & 4 deletions test/shoulda/context_test.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
require 'test_helper'

class ContextTest < PARENT_TEST_CASE
def self.context_macro(&blk)
context "with a subcontext made by a macro" do
def self.context_macro(type:, &blk)
context "with a #{type.inspect} subcontext made by a macro" do
setup { @context_macro = :foo }

merge_block(&blk)
Expand Down Expand Up @@ -36,9 +36,9 @@ def self.context_macro(&blk)
end
end

context_macro do
context_macro type: :test do
should "have name set right" do
assert_match(/^test: context with setup block with a subcontext made by a macro should have name set right/, normalized_name)
assert_match(/^test: context with setup block with a :type subcontext made by a macro should have name set right/, normalized_name)
end

should "run the setup block of that context macro" do
Expand Down