Skip to content

Add a .bytes() method to HTTP responses #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add a .bytes() method to HTTP responses #1095

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions runtime/modules/starlarkhttp/starlarkhttp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,7 @@ func (r *Response) Struct() *starlarkstruct.Struct {
"encoding": starlark.String(strings.Join(r.TransferEncoding, ",")),

"body": starlark.NewBuiltin("body", r.Text),
"bytes": starlark.NewBuiltin("bytes", r.Bytes),
"json": starlark.NewBuiltin("json", r.JSON),
})
}
Expand Down Expand Up @@ -414,6 +415,18 @@ func (r *Response) Text(thread *starlark.Thread, _ *starlark.Builtin, args starl
return starlark.String(string(data)), nil
}

// Bytes returns the raw data as bytes
func (r *Response) Bytes(thread *starlark.Thread, _ *starlark.Builtin, args starlark.Tuple, kwargs []starlark.Tuple) (starlark.Value, error) {
data, err := io.ReadAll(r.Body)
if err != nil {
return nil, err
}
r.Body.Close()
// reset reader to allow multiple calls
r.Body = io.NopCloser(bytes.NewReader(data))
return starlark.Bytes(data), nil
}

// JSON attempts to parse the response body as JSON
func (r *Response) JSON(thread *starlark.Thread, _ *starlark.Builtin, args starlark.Tuple, kwargs []starlark.Tuple) (starlark.Value, error) {
var data interface{}
Expand Down