test: add more tests for installing updates

Author: ewanharris

package-lock.json

@@ -55,6 +55,7 @@
     "@types/node": "~12.20.0",
     "@types/semver": "^7.1.0",
     "@types/sinon": "^10.0.0",
+    "@types/sinon-chai": "^3.2.5",
     "@types/tmp": "^0.2.0",
     "@typescript-eslint/eslint-plugin": "^4.3.0",
     "@typescript-eslint/parser": "^4.3.0",
@@ -77,6 +78,7 @@
     "pinst": "^2.1.6",
     "semantic-release": "^17.1.1",
     "sinon": "^11.1.1",
+    "sinon-chai": "^3.7.0",
     "tmp": "^0.2.0",
     "ts-node": "^10.0.0",
     "typescript": "^4.0.2"

package.json

@@ -117,7 +117,7 @@ describe('completions', () => {
 
 		it('Generate Alloy Completions without alloy installed', async () => {
 			mockFS({ ...mockAppcCli(true), ...mockNpmAlloy(true) });
-			expect(generateAlloyCompletions(true)).to.be.rejectedWith(Error, 'Unable to find installed alloy version.');
+			await expect(generateAlloyCompletions(true)).to.be.rejectedWith(Error, 'Unable to find Alloy');
 		});
 
 		it('Generate Alloy Completions with pre-existing completions', async () => {

tests/completions-test.ts

@@ -1,15 +1,25 @@
+import * as titaniumlib from 'titaniumlib';
+import * as path from 'path';
+import * as util from '../src/util';
+
 import execa from 'execa';
 import { appc, titanium, node, alloy, checkAllUpdates } from '../src/updates/';
-import * as util from '../src/util';
 
-import { expect } from 'chai';
+import chai from 'chai';
+import chaiAsPromised from 'chai-as-promised';
 import mockFS from 'mock-fs';
 import nock from 'nock';
 import os from 'os';
-import * as path from 'path';
+import sinon from 'sinon';
+import sinonChai from 'sinon-chai';
+
 import { mockAppcCoreRequest, mockNpmRequest, mockSDKRequest, mockNodeRequest } from './fixtures/network/network-mocks';
 import { mockAppcCli, mockNode, mockNpmCli, mockNpmInstall, mockOS, mockSdk } from './util';
 
+chai.use(chaiAsPromised);
+chai.use(sinonChai);
+const expect = chai.expect;
+
 let fixProcessPlatform: () => void|undefined;
 describe('updates', () => {
 
@@ -57,6 +67,64 @@ describe('updates', () => {
 			expect(update.hasUpdate).to.equal(false);
 		});
 
+		it('install with titanium cli', async () => {
+
+			global.sandbox
+				.stub(titaniumlib.sdk, 'install')
+				.resolves('');
+
+			const execStub: sinon.SinonStub = global.sandbox.stub(util, 'exec');
+
+			const selectStub = execStub
+				.withArgs('ti', sinon.match.any, sinon.match.any)
+				.resolves({ stdout: '{}' } as execa.ExecaReturnValue);
+
+			mockNpmCli(execStub, 'titanium', '5.3.0');
+
+			await titanium.sdk.installUpdate('8.0.0.GA');
+			expect(selectStub).to.have.been.calledOnceWith('ti', [ 'sdk', 'select', '8.0.0.GA' ], { shell: true });
+		});
+
+		it('install with appc cli logged in', async () => {
+			global.sandbox
+				.stub(titaniumlib.sdk, 'install')
+				.resolves('');
+
+			const execStub: sinon.SinonStub = global.sandbox.stub(util, 'exec');
+
+			const whoamiStub = execStub
+				.withArgs('appc', [ 'whoami', '-o', 'json'], sinon.match.any)
+				.resolves({ stdout: '{ "username": "bob" }' } as execa.ExecaReturnValue);
+
+			const selectStub = execStub
+				.withArgs('appc', [ 'ti', 'sdk', 'select', '8.0.0.GA' ], sinon.match.any)
+				.resolves({ stdout: '' } as execa.ExecaReturnValue);
+
+			mockNpmCli(execStub, 'titanium');
+			mockAppcCli(execStub, '6.6.6', '4.2.13');
+
+			await titanium.sdk.installUpdate('8.0.0.GA');
+			expect(whoamiStub).to.have.been.calledOnceWith('appc', [ 'whoami', '-o', 'json' ], { shell: true });
+			expect(selectStub).to.have.been.calledOnceWith('appc', [ 'ti', 'sdk', 'select', '8.0.0.GA' ], { shell: true });
+		});
+
+		it('install with appc cli logged out', async () => {
+			global.sandbox
+				.stub(titaniumlib.sdk, 'install')
+				.resolves('');
+
+			const execStub: sinon.SinonStub = global.sandbox.stub(util, 'exec');
+
+			execStub
+				.withArgs('appc', [ 'whoami', '-o', 'json'], sinon.match.any)
+				.resolves({ stdout: '{}' } as execa.ExecaReturnValue);
+
+			mockNpmCli(execStub, 'titanium');
+			mockAppcCli(execStub, '6.6.6', '4.2.13');
+
+			await expect(titanium.sdk.installUpdate('8.0.0.GA')).to.eventually.be.rejectedWith('Failed to select SDK as you are not logged in');
+		});
+
 		it('getReleaseNotes()', () => {
 			expect(titanium.sdk.getReleaseNotes('10.0.0.GA')).to.equal('https://titaniumsdk.com/guide/Titanium_SDK/Titanium_SDK_Release_Notes/Titanium_SDK_Release_Notes_10.x/Titanium_SDK_10.0.0.GA_Release_Note.html');
 		});
@@ -121,6 +189,16 @@ describe('updates', () => {
 			expect(update.hasUpdate).to.equal(false);
 		});
 
+		it('installUpdate()', async () => {
+			const stub = global.sandbox.stub(util, 'exec')
+				.withArgs('npm', sinon.match.any, sinon.match.any)
+				.resolves({ stdout: '' } as execa.ExecaReturnValue);
+
+			await appc.install.installUpdate('6.6.6');
+
+			expect(stub).to.have.been.calledOnceWith('npm', [ 'install', '-g', '[email protected]', '--json' ], { shell: true });
+		});
+
 		it('getReleaseNotes()', () => {
 			expect(appc.install.getReleaseNotes()).to.equal('https://titaniumsdk.com/guide/Appcelerator_CLI/Appcelerator_CLI_Release_Notes/');
 		});
@@ -184,6 +262,16 @@ describe('updates', () => {
 			expect(update.hasUpdate).to.equal(true);
 		});
 
+		it('installUpdate()', async () => {
+			const stub = global.sandbox.stub(util, 'exec')
+				.withArgs('appc', sinon.match.any, sinon.match.any)
+				.resolves({ stdout: '' } as execa.ExecaReturnValue);
+
+			await appc.core.installUpdate('6.6.6');
+
+			expect(stub).to.have.been.calledOnceWith('appc', [ 'use', '6.6.6' ], { shell: true });
+		});
+
 		it('getReleaseNotes()', () => {
 			expect(appc.core.getReleaseNotes('6.6.6')).to.equal('https://titaniumsdk.com/guide/Appcelerator_CLI/Appcelerator_CLI_Release_Notes/Appcelerator_CLI_Release_Notes_6.x/Appcelerator_CLI_6.6.6_GA_Release_Note.html');
 		});

tests/updates-test.ts

@@ -16,7 +16,7 @@ import execa from 'execa';
 export function mockAppcCli (stub: sinon.SinonStub, coreVersion?: string, installerVersion?: string, mockVersionFile = false): void {
 	if (coreVersion && installerVersion) {
 		stub
-			.withArgs('appc', sinon.match.any, sinon.match.any)
+			.withArgs('appc', [ '--version', '--output', 'json' ], sinon.match.any)
 			.resolves({ stdout: `{"NPM":"${installerVersion}","CLI":"${coreVersion}"}` } as execa.ExecaReturnValue);
 
 		if (mockVersionFile) {