Skip to content

Conversation

@jannesa007
Copy link
Collaborator

Simple script for setting the network settings which will run on net-vm but can be launched also from gui-vm.

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

https://jira.tii.ae/browse/SSRCDP-10954

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run nix flake check and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • Alienware x86_64

Installation Method

  • Requires full re-installation (just build ...installer)
  • Can be updated with just rebuild ...
  • Other:

Test Steps To Verify:

  1. ...

Signed-off-by: Janne Sangi <[email protected]>
Comment on lines +39 to +43
read -e -r -p "Enter IP Address: " IP
if ipcalc -c "$IP"; then
VALID_IP=true
CON_IP=$IP
else
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? you are putting an interactive prompt on the script. just use the network manager UI to set all these.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original idea was to integrate this functionality (script) to be part of on-boarding script to just decrease the steps and simplify the process to make laptop ready. However it seems to be too tricky (at least at the moment) to do it from the on-boarding script since it is executed in the docker-vm and networking settings need to changed in the net-vm etc. @juliuskoskela and @emrahbillur tried to help me to find decent solution for this but it seems that there is no trivial solution for this. So I thought I'd do what I can now and later attach this to the on-boarding script if possible. Anyway, of course we can still use the nm-applet to set the network but this is just optional simplified and easier way which resembles the old installer's way of setting network settings.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok this does not solve that jira. and is just a replication of network manager UI but adds more steps

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Mika Juuti Julius will implement the final solution for this https://jira.tii.ae/browse/FMO-134. Meanwhile NM-applet can be used so no need for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants