-
Couldn't load subscription status.
- Fork 14
script for settings network #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Janne Sangi <[email protected]>
| read -e -r -p "Enter IP Address: " IP | ||
| if ipcalc -c "$IP"; then | ||
| VALID_IP=true | ||
| CON_IP=$IP | ||
| else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why? you are putting an interactive prompt on the script. just use the network manager UI to set all these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original idea was to integrate this functionality (script) to be part of on-boarding script to just decrease the steps and simplify the process to make laptop ready. However it seems to be too tricky (at least at the moment) to do it from the on-boarding script since it is executed in the docker-vm and networking settings need to changed in the net-vm etc. @juliuskoskela and @emrahbillur tried to help me to find decent solution for this but it seems that there is no trivial solution for this. So I thought I'd do what I can now and later attach this to the on-boarding script if possible. Anyway, of course we can still use the nm-applet to set the network but this is just optional simplified and easier way which resembles the old installer's way of setting network settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related ticket: https://jira.tii.ae/browse/FMO-124
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok this does not solve that jira. and is just a replication of network manager UI but adds more steps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to Mika Juuti Julius will implement the final solution for this https://jira.tii.ae/browse/FMO-134. Meanwhile NM-applet can be used so no need for this.
Simple script for setting the network settings which will run on net-vm but can be launched also from gui-vm.
Type of Change
Related Issues / Tickets
https://jira.tii.ae/browse/SSRCDP-10954
Checklist
nix flake checkand it passesTesting Instructions
Applicable Targets
x86_64x86_64x86_64Installation Method
just build ...installer)just rebuild ...Test Steps To Verify: