-
Notifications
You must be signed in to change notification settings - Fork 2
adds nix flake and rust feature flags. bumps solana-sdk #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @hxrts, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the project's development and build infrastructure by integrating a Nix flake, providing a reproducible environment and granular control over Rust feature compilation. It also updates core Solana dependencies and refines existing feature flag usage across the codebase, ensuring more modular and efficient builds.
Highlights
- Nix Flake Integration: Introduced a Nix flake (
flake.nix
,flake.lock
,nix/devshell.nix
) to provide a reproducible development environment and build system. This setup leveragescrate2nix
for managing Rust dependencies within Nix, defining common build inputs, environment variables, and crate overrides for various system libraries (OpenSSL, Protobuf, SQLite, RocksDB). - Rust Feature Flag Granularity: Refined the Rust feature flags in
Cargo.toml
by changing the default feature set totest-utils
only, makingcosmos
,evm
, andsolana
features explicitly opt-in. A newcoprocessor
feature was added to conditionally include thevalence-coprocessor-domain-prover
dependency. Numerous#[cfg(feature = "...")]
attributes were added across the codebase to ensure modules and code snippets are only compiled when their respective features are enabled. - Solana SDK Update and Mnemonic Support: Updated
solana-sdk
and related Solana dependencies from version2.0
to2.1.6
. As a temporary measure, mnemonic support inSolanaClient::from_mnemonic
has been disabled due to reported BIP32 compatibility issues with the new SDK version. Minor adjustments were also made to Solana RPC client methods for epoch info retrieval and transaction confirmation. - Dependency Import Refinement: Updated several Rust files to directly import
async_trait::async_trait
instead of relying ontonic::async_trait
, indicating a more direct and potentially cleaner dependency management practice.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a Nix flake for development environments, feature flags, and upgrades the Solana SDK. The changes are well-structured. The Solana from_mnemonic
function has been disabled, which is a breaking change, and the new Nix configuration is missing the coprocessor
feature in its package definitions and developer shell help text.
touches quite a few files to add feature flags, but main addition is the flake.nix