Skip to content

Conversation

gaberudy
Copy link

@gaberudy gaberudy commented Feb 9, 2019

Pop the crossReferenceKeyList after recursing down so that codegen succeeds when two siblings have the same complex type.

Pop the crossReferenceKeyList after recursing down so that codegen succeeds when two siblings have the same complex type.
@timqian
Copy link
Owner

timqian commented Feb 11, 2019

This change makes the code only check one level of parent-child relation, and will pop every crossReferenceKey (parent-child relation) away, I think it will result in bug for recursive schema. And besides, manipulating pointer parameter in recursive function make the code hard to reason about

@clayrisser clayrisser mentioned this pull request Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants