Skip to content

fix(announcements): Improve Teacher Announcement Approval UX #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

amcsz
Copy link

@amcsz amcsz commented May 3, 2025

Closes #1726

Proposed changes

  • When teacher rejects announcement, it will be hidden from their dashboard
  • When teacher approves announcement, it will stay on their dashboard and say it is waiting for admin approval. It will stay until an admin approves it

Brief description of rationale

This will create less confusion on the teacher's side of the application.

@amcsz amcsz requested a review from a team as a code owner May 3, 2025 20:29
@amcsz amcsz changed the title Improve Teacher Announcement Approval UX fix(announcements): Improve Teacher Announcement Approval UX May 3, 2025
@coveralls
Copy link

coveralls commented May 3, 2025

Coverage Status

coverage: 79.391% (+0.004%) from 79.387%
when pulling f8c8045 on amcsz:teacherux
into 0feeb1b on tjcsl:dev.

@aarushtools
Copy link
Member

Other than that looks good though!

@amcsz
Copy link
Author

amcsz commented May 22, 2025

I just squashed all the commits, there are no other changes I made other than pluralizing the text on the dashboard view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Teacher Announcement Approval UX
3 participants