Skip to content

feat(rangeset): return partial cover and uncovered elements for set cover. #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 16, 2025
Merged

feat(rangeset): return partial cover and uncovered elements for set cover. #61

merged 4 commits into from
Apr 16, 2025

Conversation

yuroitaki
Copy link
Member

@yuroitaki yuroitaki requested review from themighty1 and sinui0 April 4, 2025 06:35
@yuroitaki yuroitaki mentioned this pull request Apr 4, 2025
Merged
@themighty1
Copy link
Member

will review soon

themighty1
themighty1 approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@themighty1 themighty1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gw

sinui0
sinui0 reviewed Apr 14, 2025
View reviewed changes
Copy link
Member

@sinui0 sinui0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

Looking at this again, what do you think about simply returning (Vec<_>, Rhs)? It's now apparent this would be a simpler API, where the user can simply check if Rhs is empty to know whether it was fully covered.

@yuroitaki
Copy link
Member Author

Good work!

Looking at this again, what do you think about simply returning (Vec<_>, Rhs)? It's now apparent this would be a simpler API, where the user can simply check if Rhs is empty to know whether it was fully covered.

agreed, implemented :)

@yuroitaki yuroitaki requested review from themighty1 and sinui0 April 16, 2025 09:16
@sinui0 sinui0 merged commit 753b4b0 into dev Apr 16, 2025
3 checks passed
@sinui0 sinui0 deleted the feat/cover-enhancement branch April 16, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinui0 sinui0 sinui0 approved these changes

@themighty1 themighty1 Awaiting requested review from themighty1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuroitaki @themighty1 @sinui0