Skip to content

Mix expandables fields #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Mix expandables fields #98

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
855c2c9
set attr from interfaces.yml
Mar 26, 2024
c3f7bc7
add examples in yml
Mar 28, 2024
01ac3a1
fixing manufacturer name
Mar 28, 2024
c2dbeff
fixes
Mar 28, 2024
ac6f677
Remove test on expandables fields
Apr 8, 2024
14fde39
Merge branch 'main' into mix_expandables_fields
obedouet Apr 8, 2024
e686f87
clean_code
Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/netbox_initializers/initializers/device_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,19 +39,14 @@ def expand_templates(params: List[dict], device_type: DeviceType) -> List[dict]:
for param in params:
param["device_type"] = device_type
expanded_fields = {}
has_plain_fields = False

for field in templateable_fields:
template_value = param.pop(f"{field}_template", None)

if field in param:
has_plain_fields = True
elif template_value:
if template_value:
expanded_fields[field] = list(expand_alphanumeric_pattern(template_value))

if expanded_fields and has_plain_fields:
raise ValueError(f"Mix of plain and template keys provided for {templateable_fields}")
elif not expanded_fields:
if not expanded_fields:
expanded.append(param)
continue

Expand Down