-
Notifications
You must be signed in to change notification settings - Fork 294
Add standard for mintless jettons #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
||
This standard propose to use `custom_payload` to store there _claim airdrop_ command with the following scheme: | ||
``` | ||
merkle_airdrop_claim proof:^Cell = CustomPayload; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merkle_airdrop_claim#0df602d6 proof:^Cell = CustomPayload;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again tom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
من گیج دم چی ب چیه اصلا قاطی کردم
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine
|
||
Method `is_minted()` for jetton wallets returns `bool` whether jetton is minted or not. | ||
|
||
//TODO: make better naming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed with with mr-tron instead of get_method lets move custom_payload source to metadata. This will not cause security issue (owner silently changes metadata) since Merkle root checks are done in contracts and root won't be changed.
I propose to have:
custom_payload_augmentation_endpoint
with some specified scheme (like cNFT)
and custom_payload_augmentation_hashmap
can be link to web2, tonstorage, ipfs ...
### | ||
|
||
In metadate stored according to [Metadata standard](https://github.com/ton-blockchain/TEPs/blob/master/text/0064-token-data-standard.md) | ||
should be added field "mintles_merkle_dump_uri" with `string` type in json or `ContentData` type in TL-B: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mintles or mintless ?
### Useful links | ||
|
||
1. [Reference contract implementation](https://github.com/ton-community/mintless-jetton) | ||
2. [Custom payload API](ttps://github.com/ton-blockchain/TEPs/blob/master/text/0000-jetton-offchain-payloads.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https, missing "h" at the beginning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EQCDjUcZdVCmk7myvIuZqJ7WGC1UW0845XE2rmCPKkGWiVDO
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
In metadate stored according to [Metadata standard](https://github.com/ton-blockchain/TEPs/blob/master/text/0064-token-data-standard.md) | ||
should be added field "mintles_merkle_dump_uri" with `string` type in json or `ContentData` type in TL-B: | ||
|
||
`mintles_merkle_dump_uri` pointed to binary file contains BoC with merkle tree of all jettons wallets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure that mintless (double s) should be there
= InternalMsgBody; | ||
``` | ||
|
||
This standard propose to use `custom_payload` to store there _claim airdrop_ command with the following scheme: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to store there the
|
||
## GetMethods | ||
|
||
Method `is_claimed()` for jetton wallets returns `bool` whether jetton is minted or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method return, not returns.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Also I see that the document doesn't explicitly state what happens if the airdrop claim conditions are not met (e.g., if it's already claimed or outside the time window). It might be helpful to specify the expected behavior in these cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EQCDjUcZdVCmk7myvIuZqJ7WGC1UW0845XE2rmCPKkGWiVDO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the Mintless feature should be better described for non-TON devs to understand better how it works
|
||
### Custom payload and indexation API | ||
|
||
Described in [Jetton Offchain Payloads](https://github.com/ton-blockchain/TEPs/blob/master/text/0000-jetton-offchain-payloads.md) TEP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
URL is invalid. It leads to 404
|
||
### | ||
|
||
In metadate stored according to [Metadata standard](https://github.com/ton-blockchain/TEPs/blob/master/text/0064-token-data-standard.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In metadate
Perhaps you meant metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tonkeeper:mintles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
content/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/about-writing-and-formatting-on-github.md
### Custom payload and indexation API | ||
|
||
Described in [Jetton Offchain Payloads](https://github.com/ton-blockchain/TEPs/blob/master/text/0000-jetton-offchain-payloads.md) TEP. | ||
|
||
### GetMethods |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0x460a252b4feefa821d3351731220627d7b7d1f3d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😢🙏🫡
این من نیستم که برداشت میکنه
در تاریخ شنبه ۱۲ آوریل ۲۰۲۵، ۱۸:۰۱ Abreham Bahru ***@***.***>
نوشت:
… ***@***.**** commented on this pull request.
------------------------------
In text/0000-compressed-jetton-standard.md
<#177 (comment)>:
> +In addition to standard fields (like balance, owner, etc), this standard suggest to store `merkle_hash` 256-bit integer in JettonMaster and JettonWallet contracts. Additionally all JettonWallet contracts stores flag `already_claimed` whether airdrop was claimed or not.
+
+### Handlers
+
+Standard TEP-74 Jetton implements the `transfer` handler with the following scheme:
+
+```
+transfer#0f8a7ea5 query_id:uint64 amount:(VarUInteger 16) destination:MsgAddress
+ response_destination:MsgAddress custom_payload:(Maybe ^Cell)
+ forward_ton_amount:(VarUInteger 16) forward_payload:(Either Cell ^Cell)
+ = InternalMsgBody;
+```
+
+This standard propose to use `custom_payload` to store there _claim airdrop_ command with the following scheme:
+```
+merkle_airdrop_claim proof:^Cell = CustomPayload;
Fine
—
Reply to this email directly, view it on GitHub
<#177 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BQAFJOZH3ACRZ2YYGLRKARL2ZEPV3AVCNFSM6AAAAABLJELB2WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDONRSGE3TGNJXHA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
No description provided.