Skip to content

fix(PM-1448, PM-1322, PM-1468): QA feedbacks #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 11, 2025
Merged

fix(PM-1448, PM-1322, PM-1468): QA feedbacks #1136

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1bc239f
fix: undefined error in profile picture component
hentrymartin Jul 11, 2025
bb10a8f
fix: qa feedbacks
hentrymartin Jul 11, 2025
01975d5
fix: qa feedbacks
hentrymartin Jul 11, 2025
1d6825c
fix: qa feedbacks
hentrymartin Jul 11, 2025
e929c29
fix: qa feedbacks
hentrymartin Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ workflows:
- LVT-256
- CORE-635
- feat/system-admin
- pm-1322
- pm-1448_1

- deployQa:
context: org-global
Expand Down
2 changes: 1 addition & 1 deletion ...s/src/pages/copilot-opportunity-details/apply-opportunity-modal/ApplyOpportunityModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ const ApplyOpportunityModal: FC<ApplyOpportunityModalProps> = props => {
buttons={
!success ? (
<>
<Button disabled={!notes} primary onClick={onApply} label='Apply' />
<Button disabled={!notes.trim()} primary onClick={onApply} label='Apply' />
<Button secondary onClick={props.onClose} label='Cancel' />
</>
) : (
Expand Down
2 changes: 1 addition & 1 deletion src/apps/copilots/src/pages/copilot-request-form/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ const CopilotRequestForm: FC<{}> = () => {
setPaymentType('')
// Added a small timeout for the toast to be visible properly to the users
setTimeout(() => {
navigate('/requests')
navigate('/copilots/requests')
}, 1000)
})
.catch(e => {
Expand Down
4 changes: 2 additions & 2 deletions src/libs/shared/lib/components/profile-picture/ProfilePicture.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ const ProfilePicture: FC<ProfilePictureProps> = props => {
>
{!loaded && (
<span className={styles.profileInitials}>
{props.member.firstName.slice(0, 1)}
{props.member.lastName.slice(0, 1)}
{props.member?.firstName?.slice(0, 1)}
{props.member?.lastName?.slice(0, 1)}
</span>
)}
{props.member.photoURL && !error && (
Expand Down